Crops (Partially) Disappeared

Forged Space FS Bug Reports
1

It applies to Crops ID: 35 and 37

June 29th:
1 of your RF-49 plants have died. Crop ID:35
9 of your RF-49 plants have died. Crop ID:36
8 of your RF-49 plants have died. Crop ID:37

June 30th
6 of your RF-49 plants have died. Crop ID:35
4 of your RF-49 plants have died. Crop ID:36
1 of your RF-49 plants have died. Crop ID:37

July 1st
1 of your RF-49 plants have died. Crop ID:35
8 of your RF-49 plants have died. Crop ID:36
10 of your RF-49 plants have died. Crop ID:37
7 of your RF-49 plants have died. Crop ID:38

July 2nd
1 of your RF-49 plants have died. Crop ID:35
7 of your RF-49 plants have died. Crop ID:36
4 of your RF-49 plants have died. Crop ID:37
3 of your RF-49 plants have died. Crop ID:38

July 3rd
5 of your RF-49 plants have died. Crop ID:35
6 of your RF-49 plants have died. Crop ID:36
1 of your RF-49 plants have died. Crop ID:37
13 of your RF-49 plants have died. Crop ID:38

July 4rth
1 of your RF-49 plants have died. Crop ID:36
5 of your RF-49 plants have died. Crop ID:38

Total losses:
Crop ID:35 = 1 + 6 + 1 + 1 + 5 + 0 = 14 => 200 - 14 = 186 should be left
Crop ID:36 = 9 + 4 + 8 + 7 + 6 + 1 = 35 => 200 - 35 = 165 => correct
Crop ID:37 = 8 + 1 + 10 + 4 + 1 + 0 = 24 => 200 - 24 = 176 should be left
Crop ID:38 = 7 + 3 + 13 + 5 = 28 => 400 - 28 = 372 => correct

Currently Laboratories Manufacturing
ID / Laboratories Active / Total Units Left / Time Until Completed
36 / 2 / 165 / 1 day
35 / 2 / 119 / 1 day
38 / 4 / 372 / 2 days (should be 3 days ?)

So on the 4rth
Crop ID: 35 no message plants died by events, but it turns out 67 disappeared
Crop ID: 37 no message plants died by events, but all 176 disappeared

2

I am going to need to work through this when I am not so tired, but I suspect it may be related to the issue with the rollover yesterday.

Do the stats on your current labs stack up correctly after the roll just passed, or are the numbers still off?

3

Yes, the stats after the latest roll stacked up as they should.

4

Saw the same thing, went from 92 to 31 without any message in events 2 days ago, today message was correct lost 2 and went to 29

5

Have we seen any more issues with the crops since I fixed the issue in the rollover code?

I have been through the code and process numerous times and cannot see anywhere that crops should be vanishing. Would appreciate any feedback and stats you guys may have on this.

6

Yogan mentioned “2 days ago”, so that could have been the same issue as mine from before you fixed the rollover code

7

agreed, only saw it happen on 1 day only, no event was shown and Ilost a huge amount of enzymes, all other days rollover has shown an event and the correct amount was deducted.

8

spoke too soon, its messed up again, rollover occurred and only 1 event message from Crop ID:50, no event message from Crop ID:40 and lost another 24 enzymes thats a total of 89 lost so far without any event warning.

9

Ok, I have made another tweak to the rollover ticker, and adjusted the logic slightly. Please keep an eye on your crops and let me know if any more issues occur.

10

Something is still wrong.

For one crop I didn’t get a message in the last rollover
That was Crop ID: 44

Calculations from Events:
Crop / Plants died
ID: 44 / 7 + 3 + missing event = 10 => 190 left
ID: 45 / 1 + 1 + 9 = 11 => 189 left
ID: 46 / 3 + 4 + 6 = 13 => 187 left
ID: 49 / 6 + 7 = 13 => 387 left

Product / No. of Labs / Units / Time Until Completed
RF-49 / 2 / -15 / 3 days => false
RF-49 / 2 / 189 / 3 days => correct
RF-49 / 4 / 387 / 5 days => correct
RF-49 / 2 / 187 / 3 days => correct

So now the ID also disappeared in the “Manage Property” page.

I get the impression sometimes a “missing value” is generated for events.
Could it be a problem in the RNG?
Could a “0” crops died cause this?

11

That was my thinking. I hadn’t touched this portion of the code as initial testing had highlighted no issues. I have adjusted the ticker so you should now get notification if no crops die.

I removed this to add more data, but will squeeze it back in.

12

Last rollover worked as expected.

Crops / plants died / left
ID: 44 / 3 => -18 ( I rather had it diappear than keep growing in negatively)
ID: 45 / 7 => +182
ID: 46 / 8 => +179
ID: 49 / 13 => +374

13

There were a couple of rows in the table that slipped into negatives. I have bounced both of those to 100, as a means to keep testing, and also compensation of sorts for the issues.

Fingers crossed we got to the bottom of it.

14

Went negative in my messed up lab on New Orion
ID 40 RF-49 Units -3

15

This will be the cleanup portion of the code, was wrong, so have fixed it. Did the numbers stack up though ? With losses should it have been -3 or was the calculation wrong?

16

With Crop ID: 44 reset at 100, this is the result for last rollover:

Crops / plants died / left
ID: 44 / 1 => + 99
ID: 45 / 5 => +177
ID: 46 / 10 => +169
ID: 49 / 18 => +356

All are correct. Rollover works as it should.

17

Calculation was corrent last rollover

18

:smile:

Finally feel like we are getting somewhere…

Keep me appraised guys if anything else untoward happens with the crops…

19

I cashed Crops ID 44, 45 and 46 without further anomalies

20

I had a 0 died event on 1 crop. It worked out as it should be, so probably you fixed the bug.